Vue 3 Working Group Disbanding
Why is this change being made?
The Vue 3 working group is not meeting its purpose for several reasons:
- The scope of the working group is too large
- The members list does not reflect who's actually working on this migration
- We're getting too bogged down in the actual migrations instead of solving the hard problems and pulling in support from the wider org.
Because of this, the plan is to disband the working group and split the important tasks into smaller, more focused, task groups. This way we can get the right people on the right problems at the right time and can work in parallel where it makes sense.
Note: For the current ask of migrating all the tests, our plan is to tighten the rules on the failing jobs and leave the migrations to GitLab engineers. I'll add this to the handbook seperately.
Author and Reviewer Checklist
Please verify the check list and ensure to tick them off before the MR is merged.
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- The when to get approval handbook section explains the workflow in more detail
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
For transparency, share this MR with the audience that will be impacted. -
Team: For changes that affect your direct team, share in your group Slack channel -
Department: If the update affects your department, share the MR in your department Slack channel -
Division: If the update affects your division, share the MR in your division Slack channel -
Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR - For high-priority company-wide announcements work with the internal communications team to post the update in #company-fyi and align on a plan to circulate in additional channels like the "While You Were Iterating" Newsletter
-
Merge request reports
Activity
added HandbookContent label
assigned to @samdbeckham
- Resolved by Sam Beckham
Using combined codequality.json
️ Pipeline Failure - Linting ErrorsOne of the linters has reported errors and as a result the pipeline has failed. Once the pipeline completes, you'll find the code quality report above which can link you to where the error is in your code. Additionally, below you'll find a table of the errors. The table has links to the lint rules so you can find more information on how to fix the issue(s).
If you need more help please reach out on Slack in #mr-buddies.
Edited by ****
- Resolved by Sam Beckham
- Resolved by Sam Beckham
- Resolved by Sam Beckham
- Resolved by Sam Beckham
- Resolved by Sam Beckham
- Resolved by Sam Beckham
- Resolved by Sam Beckham
@samdbeckham LGTM. Should I be added to the list of members for historical tracking purposes?
added 43 commits
-
465e0ccf...2af6f5f3 - 40 commits from branch
main
- 01565768 - Disbands the Vue 3 working group
- 33b4d473 - Shrinks the exit criterea table
- 2f2bde17 - Adds info on the continuations
Toggle commit list-
465e0ccf...2af6f5f3 - 40 commits from branch
- Resolved by Sam Beckham
Using combined codequality.json
️ Pipeline Failure - Linting ErrorsOne of the linters has reported errors and as a result the pipeline has failed. Once the pipeline completes, you'll find the code quality report above which can link you to where the error is in your code. Additionally, below you'll find a table of the errors. The table has links to the lint rules so you can find more information on how to fix the issue(s).
If you need more help please reach out on Slack in #mr-buddies.
cc @ntepluhina @marina.mosti @arfedoro @vanessaotto as the more recent active members of the working group, do you have any comments or concerns before we merge this?
53 | [Get CustomersDot running with Vue Compat mode 2](https://gitlab.com/groups/gitlab-org/-/epics/12388) | 2024-02-01 | 2024-04-30 | 0% | [@vitallium](https://gitlab.com/vitallium) | 54 | [Switch Vue Compat from mode 2 to mode 3](https://gitlab.com/groups/gitlab-org/-/epics/12389) | 2024-05-31 | 2024-10-31 | 0% | TBD | 55 | [Switch to using Vue 3 proper](https://gitlab.com/groups/gitlab-org/-/epics/12390) | 2024-10-31 | 2025-12-01 | 0% | TBD | 54 As this group has been disbanded, bot all exit criteria has been met. 55 The main items have been picked up by related taskforces. 56 The final two will be picked up once they're unblocked. 57 58 | Criteria | Start Date | End Date | Progress | DRI | Continued | 59 | ---------------------------------------------------------- | ---------- | ---------- | -------- | ------------------------ | ----------------------- | 60 | [Get Bootstrap Vue running with Vue Compat mode 2][exit1] | 2021-06-21 | 2022-10-25 | 100% | [@xanf][@xanf] | Complete | 61 | [Get GitLab UI running with Vue Compat mode 2][exit2] | 2021-06-21 | - | 70% | [@markrian][@markrian] | [GitLab UI Taskforce][] | 62 | [Vue Compat mode on vue-router on GitLab Main][exit3] | 2023-05-18 | - | 50% | TBD | ??? | 63 | [Use Vue.js 3 for running test suites on main repo][exit4] | 2023-05-18 | - | 30% | [@xanf][@xanf] | Company Responsibiity | 64 | [Get CustomersDot running with Vue Compat mode 2][exit5] | 2024-02-01 | - | 0% | [@vitallium][@vitallium] | ??? | 65 | [Switch Vue Compat from mode 2 to mode 3][exit6] | - | - | 0% | TBD | TBD | 66 | [Switch to using Vue 3 proper][exit7] | - | - | 0% | TBD | TBD | Building up on @vanessaotto's comment above, where do satellite apps like Switchboard fall into the timeline? fomo
changed this line in version 5 of the diff
That's a good callout @vanessaotto The original intent was to do these steps for all repos as there should be less work than getting them all running in compat mode 2. However, with the disbanding, I would leave this decision up to the (eventual) task group creators. It may make more sense to split the work differently and have task groups around each satellite project.
@marina.mosti this is the old timeline and one of the reasons we want to split this into smaller, more focused, task groups. Switchboard can fit into this timeline whenever y'all are ready. What would be the blockers for getting switchboard on full Vue3 mode? If there are none, then you can start this process now. If there are blockers, then I'd encourage you to evangelize this and make sure someone is looking at those blockers.
I'm merging this MR now but we can move this to a follow-up if this needs more discussion.
Hey @samdbeckham thanks for resurfacing this.
From the perspective of Switchboard we are already running Vue 3 (as you know) with compat fully. In order for us to remove compat we would need gitlab UI to also not be throwing compat errors and warnings. It'll be quite difficult (I expect) for us to parse through the warnings when most of them are coming from gitlab UI.
We have a currently suboptimal way to silence all the compat warnings in Jest, which may be the first step.
We'll keep an eye out on gitlab UI pushing, and I'm looking forward to finding a way to collaborate on this migration. I think with Switchboard being one step ahead of monorepo its a good opportunity to test-drive in a smaller more controlled repo how the steps will look for the big gitlab org migration.
Curious what @leipert and @markrian think about this one, or if they have already established or idealized some general structure plan for the migration.
FYI @glin5
I've opened a follow up issue on our end for this here https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/team/-/issues/6700
@marina.mosti @markrian is OOO for a little while but just before he left he started the GitLab UI vue compat task group. Your input in that group would be really valuable
- Resolved by Sam Beckham
mentioned in merge request !9222 (merged)
Using combined codequality.json
Pipeline Failure - Linting ErrorsOne of the linters has reported errors and as a result the pipeline has failed. Once the pipeline completes, you'll find the code quality report above which can link you to where the error is in your code. Additionally, below you'll find a table of the errors. The table has links to the lint rules so you can find more information on how to fix the issue(s).
Rule File Line Error handbook.RelativeLinks content/handbook/company/working-groups/vuejs-3-migration.md 61 Use a relative link instead of the full URL. If you need more help please reach out on Slack in #mr-buddies.
added 676 commits
-
2574a7f7...f982b8b1 - 675 commits from branch
main
- 1dadf05a - Disbands the Vue 3 working group
-
2574a7f7...f982b8b1 - 675 commits from branch
started a merge train
mentioned in commit 711f1535