Skip to content

Remove workflow verification label from FedRAMP DR procedure

Cameron Swords requested to merge remove-workflow-label-fedramp into main

What does this MR do?

Removes the addition of the workflowverification label from being applied to new Deviation Request vulnerability issues.

In theory, this label is not required as ~FedRAMP::DR Status::Open can be used to find open issues.

Why is this change being made?

Denoting an issue as in workflowverification as soon as it has been opened is inconsistent with how product teams use the workflow label. This affects team metrics, and causes the issue to show on team issue boards as awaiting release when work on the issue has not begun.

How Product defines the label

The handbook states states:

In general, if an issue is in workflow::in review or workflow::verification it is very close to shipping.

When hovering the mouse over the label in GitLab.com, the following tooltip appears:

Screenshot

Reference

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Edited by Cameron Swords

Merge request reports