Skip to content

Introduces Product Security Engineering to the handbook

Nick Malcolm requested to merge product-security-engineering into main

Why is this change being made?

Product Security Engineering is a new team in the Security Engineering sub-department. As we work through the formation & transition we can start capturing information in our organisation Single Source of Truth, the handbook!

Content following hot on the heels of this will be things like links to role descriptions, our workflow, our roadmap, metrics, etc. For now this is effectively a placeholder with some content copy-pasted from the internal announcement doc.

Examples of questions asksed / issues opened in (maybe) the wrong place

Having a handbook page helps team members ask the right questions in the right places. Here are some examples of where this handbook MR could have helped:

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Nick Malcolm

Merge request reports