Skip to content

Remove default reviewer

Cynthia "Arty" Ng requested to merge arty-mr-template into main

Why is this change being made?

Updates the MR template to remove username as default reviewer. Also moved it up to be more obvious and follow the same order as the UI.

From Slack:

marin 09:17 @Jamie pinging you because I’ve seen you work on the handbook, but please redirect this to whom it matters. I’ve seen in a number of our templates in handbook sites that we have a line like https://gitlab.com/gitlab-com/content-sites/handbook/-/blob/1ecfce5c65da1dc2d32c3d68a0f4d0ddef8765cc/.gitlab/merge_request_templates/Default.md#L41 . I “name squatted” the account and now all MR’s get assigned to that user https://gitlab.com/codeowner-maintainer-or-manager . Would be good to replace that across all templates with a comment or something else because I do not think people notice what that line does.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Cynthia "Arty" Ng

Merge request reports