Skip to content

Update the MR review section

Anna Vovchenko requested to merge anna_vovchenko-main-patch-91877 into main

Why is this change being made?

Environments group domain requires a rather complex setup and broader context for performing reviews. It leads us to often stick to requesting reviews within the team or from a limited pool of maintainers.

In one of my recent MRs, I spotted a great example of clear and efficient communication performed by @hustewart. While not requesting any code changes, Hunter provided a note for the maintainer with a context for the change. It helped to get an MR reviewed and merged promptly.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Division: If the update affects your division, share the MR in your division Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Update the MR review section

Merge request reports