Skip to content

Update PD review process to design DRI

Taurie Davis requested to merge tauriedavis-main-patch-73928 into main

Why is this change being made?

Awhile back we changed our MR review process for designers to utilize review roulette and be assigned MRs from other product areas. We documented the benefits of this process in the handbook.

However, we are hearing that designers are overloaded with MR reviews and we are stacking too many things during a critical point (merging code into production):

  • Learning a new feature/area
  • Getting it set up locally
  • Understanding the agreed upon UX
  • Ensuring edge cases are looked at and addressed

This takes a lot of time since designers reviewing have to read up on what is being requested, internalize it, get it working locally, understand what to test and look for, and ask questions when they don’t understand.

The goal of this MR is to change the way we perform MR reviews within UX. It removes references to designers of other stage groups reviewing MR.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Merge request reports