Skip to content

Ability to assign multiple reviewers per merge request

Andrey Ruzmanovrequested to merge
multiple_mr_reviewers into main

Why is this change being made?

As discussed during Switchboard Team sync, we'd like to add multiple reviewers per merge request. This practice will have several benefits:

  • Raise awareness for every developer on current changes being made
  • Reduce merge request time by utilising time zone differences
  • Frontend and Backend parts of the MR can be reviewed by Frontend and Backend developers independently
  • Better chances to catch critical issues with more eyes on the MR

%{all_commits}

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Andrey Ruzmanov

Merge request reports