Skip to content

Implement improved controlled document handling

Jamie Maynard requested to merge fix-production-architecture-page into main

Why is this change being made?

  • Implement improved controlled document handling

This rather large MR improves controlled document handling and implements linting against the CODEOWNERS file and Controlled Documents. What this means is that we'll check for missing files listed in CODEOWNERS and duplicate entries. We'll also check to make sure files listed in the [controlled-documents] section of CODEOWNERS are listed as such in the files front matter and that any file who's front matter says its a controlled_document that it has a matching entry in CODEOWNERS.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Merge request reports