Add how approvals are captured for launches

Why is this change being made?

To answer this question from gitlab-org/create-stage#13291 (comment 2903805097)

probably the best way to capture it for future reference and papertrail would be a comment in the Rollout issue with explicit action. 🤔 Do you think it's worth documenting that as strict requirement or only a recommendation?

We should capture the approval from the DRIs in the related merge request or issue. This provides a papertrail that is not ephemeral and can be traced back over time.

This will be helpful to understand the group decisions historically, allows for the DRI to add any additional commentary on their approvals, and allows a way to link to follow-up issues (if necessary).

CHANGEME

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct
    • The when to get approval handbook section explains when DRI approval is required
    • The who can approve handbook section explains how to identify the DRI
    • If the MR does not require DRI approval, consider asking someone on your team, such as your manager.
    • The approver may merge the MR. If they approve but don't merge, you can merge.
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Division: If the update affects your division, share the MR in your division Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Add how approvals are captured

Merge request reports

Loading