Skip to content

Update Runner Admission Controller design to align with Job Router architecture

Why is this change being made?

This MR updates the GitLab Runner Admission Controller design document to align with the newer GitLab Runner Job Router architecture. The original design was created before the job router blueprint and contained outdated approaches.

Key changes:

  • Updated architecture from webhook-based to gRPC streaming connections
  • Focused on security with binary accept/reject decisions (removed job mutations)
  • Added runner registration and controller discovery mechanism
  • Documented hierarchical processing (instance → group → project)
  • Integrated with KAS Job Router for Phase 1 implementation

This ensures the admission controller design is consistent with the overall job router architecture while maintaining focus on its core security purpose.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct
    • The when to get approval handbook section explains when DRI approval is required
    • The who can approve handbook section explains how to identify the DRI
    • If the MR does not require DRI approval, consider asking someone on your team, such as your manager.
    • The approver may merge the MR. If they approve but don't merge, you can merge.
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Division: If the update affects your division, share the MR in your division Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Update Runner Admission Controller design to align with Job Router architecture

Edited by Joe Burnett

Merge request reports

Loading