Skip to content

Removing malformed emoji

Tony Marsh requested to merge tmarsh1-main-patch into main

Why is this change being made?

💡 Provide a detailed answer to the question on why this change is being proposed, in accordance with our value of Transparency.

Removing malformed emoji leftover from the recent handbook page move, for readability purposes. Discussed with Jamie on Slack first:

Tony
 5:11 PM
as a new hire, and a fellow London resident, 'lo!
I spotted a malformed emoji in the accounts-payable handbook page while going through onboarding today:
https://gitlab.com/gitlab-com/content-sites/handbook/-/blame/main/content/handbook/finance/accounts-payable/_index.md#L97
And was going to fix it but a> it's right at the end of a day of ingesting text and my brain is fried, and b> looks like it's survived a few revisions, so to buy myself time I wanted to check to make sure it wasn't deliberate? :slightly_smiling_fac
Jamie
  5:56 PM
So in the old handbook it wouldn’t have displayed at all… I shall roll a fix tomorrow :slightly_smiling_face:
Tony
 6:06 PM
Oh, more than happy to fix it, if not just as a learning experience, just lacking the brain power this day.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Merge request reports