Skip to content

WIP: Resolve "Dashboard Topbar: Show correct region for role (or correct role for region)"

Michael Aydinbas requested to merge 52-pmayd-fix-user-role-on-dashboard into master

Closes #52 (closed)

What does this MR do?

Because a user can have multiple roles and multiple districts, following the comment on #52 (closed) I decided to remove the user role (think it was the highest role in fs_foodsaver?) from dashboard. In addition, I added "Stammbezirk:" in front of the home district (what about multilanguage? How are texts translated? How does the s() function work?)

In the end, I am not happy with this solution because I think the dashboard is the right place for a user to look for all information about their activities and commitments. So we should add the roles of the user as an additional block in the marginals.

How confident are you it won't break things if deployed?

Very confident.

Links to related issues

See my comment on the issue: #52 (comment 132206036)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports