Fix links to the mailbox
Closes #1882 (closed)
What does this MR do?
Links in a region's menu to the mailbox should open that region's mailbox, while links from the desktop should open a specific email. Both were using a &show={id}
parameter. I separated them into &mailbox={id}
and &email={id}
.
How confident are you it won't break things if deployed?
very sure
Links to related issues
How to test
Try both links:
- any email on the dashboard
- the link to a region's mailbox from that region's page
In both cases, the correct mailbox should be selected in the mailbox module. In the first case, that email should be visible.
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text in the release notes to /release-notes/YYYY-MM.mdalready included in !3108 (merged) -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Closes #1882 (closed)
Edited by Alex