Topbar: Follow up to fix quite some bugs.
Closes/Fixes
- Closes some bugs in here: https://gitlab.com/foodsharing-dev/foodsharing-beta-testing/-/issues/34
- #1008 (closed)
What does this MR do?
It fixes some bugs related to changes making topbar responsive. Also login is now on extra page, because login popover increased problems e.g. for iPhone/Mac.
How confident are you it won't break things if deployed?
Pretty, because only small adjustments are made.
Links to related issues
Any relevant links (issues, documentation, slack discussions).
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver/foodsharer
- Resize window in with different user roles.
Screenshots (if applicable)
Any relevant screenshots if this is a design / frontend change
Checklist
-
added a test, or explain why one is not needed/possible... (not needed, because almost only styling) -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text
siehe !1532 (merged)
Edited by Rafael