Skip to content

Extract some store translation work from StoreEdit

Chris Oelmueller requested to merge refactor/translate-store-bubble into master

What does this MR do?

  • Remove some duplicate translations + Consolidate store breadcrumb translations
  • Modernize store bubble translations (extracted from !1469 (closed))
  • Add new store status "does no longer exist" for permanently closed stores (they don't show up on the map)
  • Minor trafficlight cleanup and de-Germanization

How confident are you it won't break things if deployed?

Should be okay. I didn't test the quiz change exhaustively, yet.

Links to related issues

How to test

  • configure a store so that various public info shows up on the map bubble
  • visit page=map&bid=1234 (whichever ID your store has)
  • also check the main store screen, the store-edit screen
  • play around with the traffic light stuff (set different values)
  • and of course check the traffic light usage in the quiz

Checklist

  • might need to adjust a test that expects being able to change the store status
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Chris Oelmueller

Merge request reports