Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • A adblockpluschrome
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • eyeoeyeo
  • adblockplus
  • adblockpluschrome
  • Issues
  • #99
Closed
Open
Issue created Oct 21, 2019 by Thomas Greiner@ThomasGreinerMaintainer

Remove code related to anti-adblock notification

Background

We are currently working on removing the anti-adblock notification (see https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/43). That change will be made available as part of #96 (closed). However, we can already go ahead and stop importing that code and remove any other code that's specific to or only used by that notification.

What to change

  • Stop using adblockplusui/lib/antiadblockInit.js.
  • Stop importing translations from adblockplusui/locale/*/antiadblockInit.json.
  • Remove code that preinstalls the "Adblock Warning Removal List" filter list.
  • Deprecate the "subscriptions_antiadblockurl" preference.
  • Remove code that's specific to "question"-type notifications.
  • Remove code specific to "urlFilters" notification targeting option.

Hints for testers

With this change:

  • The "Adblock Warning Removal List" filter list should no longer be automatically added.
  • For users who already have that filter list, it should be left installed.
  • If that filter list is present, it's still considered a default subscription like the others and so shouldn't prevent the default subscriptions from being automatically re-added.
  • Notifications can no longer be of type "question", nor target specific URLs with the "urlFilters" option.
  • Notifications should otherwise behave as before.
Edited Oct 22, 2019 by Dave Vandyke
Assignee
Assign to
Time tracking