Skip to content

Update adblockplusui dependency to c88622e1624d (release-2019-3)

Background

This imports the following changes: https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/compare/compat-next-2020-1...release-2019-3

See also Release 2019-3.

What to change

  • Change adblockplusui dependency to hg:c88622e1624d git:5cc28b5.
  • Make sure that the following changes are included:
  • Update metadata.base:
    • Import the following files:
      • problem.html
      • problem.js
      • data/locales.json
      • data/updates.json
      • skin/icons/toolbar/default-{size}.png as icons/abp-{size}.png
      • skin/icons/toolbar/notification-{size}.png as icons/abp-{size}-notification.png
      • skin/icons/toolbar/whitelisted-{size}.png as icons/abp-{size}-whitelisted.png
      • skin/problem.css
      • skin/fonts/source-sans-pro-300.woff2
      • skin/fonts/source-sans-pro-400.woff2
      • skin/fonts/source-sans-pro-700.woff2
      • skin/icons/checkmark-green.svg
      • skin/icons/donate.svg
      • skin/icons/email-white.svg
      • skin/icons/facebook-white.svg
      • skin/icons/filter-list-title.svg
      • skin/icons/filter-list-url.svg
      • skin/icons/fixes.svg
      • skin/icons/improvements.svg
      • skin/icons/mac.svg
      • skin/icons/open-link.svg
      • skin/icons/share.svg
      • skin/icons/share-on-facebook.svg
      • skin/icons/share-on-twitter.svg
      • skin/icons/twitter-white.svg
      • skin/icons/update.svg
      • skin/icons/warning.svg
      • skin/icons/windows.svg
      • skin/icons/problem/data-corrupted.png
      • skin/icons/updates/panda.gif
    • Stop importing the following files:
      • data/languages.json
      • skin/fonts/font.css as skin/fonts/font.css
      • skin/fonts/300/*
      • skin/fonts/400/*
      • skin/fonts/700/*
      • skin/icons/updates/*
    • Import translations from the following files:
      • locale/*/problem.json
      • locale/*/updates-latest.json
  • Remove the following files:
    • adblockpluschrome/icons/abp-{size}.png
    • adblockpluschrome/icons/abp-{size}-notification.png
    • adblockpluschrome/icons/abp-{size}-whitelisted.png
  • ui#43
    • Stop using adblockplusui/lib/antiadblockInit.js.
    • Stop importing translations from adblockplusui/locale/*/antiadblockInit.json.
    • "Adblock Warning Removal List" filter list no longer needs to be installed during first-run because we no longer use it.
    • "subscriptions_antiadblockurl" preference can be removed because it's no longer being used.
    • Support for "question" notification type can be removed because it's no longer being used.
    • Support for "urlFilters" notification targeting option can be removed because it's no longer being used.
  • ui#562
    • Allow notifications to open updates.html using "abp:updates".
    • Call showUpdatesNotification() from lib/notifications.js instead of opening updates.html directly.
      • Remove existing platform restriction so that it will be shown on all supported platforms.
      • Our plan is to increment the updatesVersion number in adblockplusui/lib/prefs.js for each major update in order to trigger the updates notification each time.
    • Renamed lib/day1Init.js to lib/notifications.js.
  • ui#565
    • adblockplusui no longer requires any Python packages for building.
  • ui#589
    • Allow notifications to open problem.html using "abp:problem".
    • Except for Firefox Mobile: Call showProblemNotification() from lib/notifications.js instead of opening the first-run page in case of a data corruption issue or filter list reinitialization. This should be unaffected by the suppress_first_run_page preference.
    • For Firefox Mobile, keep showing the first-run page in case of problems.
    • Renamed lib/day1Init.js to lib/notifications.js.

Hints for testers

  • Toolbar icon should look and behave as expected (incl. whitelisted state, during notification animation).
  • Day1, problem and updates notifications should work as expected (incl. link in them for opening the respective landing page).
  • Data corruption message should continue to be shown as part of first-run page in Firefox Mobile, instead of showing the new problem notification.
  • The expected fonts should be used in UI pages (i.e. Source Sans Pro except for characters which it doesn't support).

See hints for testers in individual issues.

Edited by Thomas Greiner