Skip to content

Draft: chore: Initial integration of elm review

aszen requested to merge aszenz/exosphere:devx/explore-integrating-elm-review into master

Overview

To make the review process more streamlined and consistent we can integrate elm-review. It's a static analysis tools that runs rules and reports code violating those rules and offering to fix them. Elm review is most useful when making one's custom rules and detecting dead code.

Fixes #878 (closed)

How to Test

Run npm run elm:review, see the errors it reports and if there are any issues we actually care about or not, modify review/src/ReviewConfig.elm to enable/disable certain rules.

We can also check out more rules by searching https://package.elm-lang.org/ with elm-review-

If we don't want to fix existing issues but only report on new issues (that is keep new code to higher standards), elm-review has a suppress feature: https://github.com/jfmengels/elm-review/tree/2.13.0#temporarily-suppressing-errors

Screenshots

N/A

Merge request reports