elm-review rule to avoid hard-coding Font.size
Problem/Opportunity Statement
!740 (merged) represents a bunch of work to standardize use of font sizes throughout all the view code.
To avoid backsliding, it feels appropriate to set a policy for the project:
Avoid hard-coding Font.size
in widgets or pages. Get your font size from the Text
widget instead.
We could put this in the MR Quality Checklist, but then we're introducing another thing for contributors and maintainers to remember to check when building or reviewing an MR (respectively).
We could have computers do this work for us instead.
What would success / a fix look like?
!845 (merged) introduced elm-review. We could encode the above policy in a review rule.
(There are probably other easy wins from doing this for other items on the MR quality checklist too, like enforcing use of the Spacer
widget. Perhaps introduce review rules for those as separate MRs.)