Skip to content

Use asyncio locks to limit race condition

Andrewrequested to merge
bugfix/upload-race-condition into dev

What does this MR do and why?

  • Utilize asyncio locks to prevent file merging before chunk uploads are complete.
  • Resolve race condition in upload handling logic.
  • Resolves #602

I've tested this to ensure it does not break normal uploads - it does not. I've been unable to reproduce this issue except for one time so I'm unsure if this actually fixes the problem, but logically it should.

How to set up and validate locally

COMPLETELY INTERMITTENT

  • Upload a file larger than 100mb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Andrew

Merge request reports