Skip to content

Resolve "Cluster failed to be detected when in close proximity to the vehicle"

Description

Part of #855 (closed).

This MR aims allow for clusters to be detected by the euclidean clustering algorithm when in close proximity to the vehicle. This MR closes #864 (closed).

The pointcloud_filter_transform_node was filtering out points based on a min_radius parameter. Previously, this parameter was set to 6.0m which resulted in many points in close proximity to the vehicle to have been filtered out. Reducing this value to 3.0m greatly increases the number of points while also ensuring that the points belonging to the vehicle have been filtered out. Some examples of the issue are below:

Before (min_radius = 6.0) min_radius_6

After (min_radius = 3.0) min_radius_3

Notes for reviewer

This can be tested by running the AVP demo instructions with the addition of enabling NPCs using (ctrl+n). Then driving up to and hitting an NPC. You'll notice that with this MR that agents will continue to be detected by the euclidean clustering algorithm as the points are no longer filtered out.

In addition to this parameter value change, the parameter file (which was once directly referenced by prefixing with the pointcloud filter transform package) has been copied to the autoware_auto_avp_demo package where it can be modified to suit the AVP demo requirements.

Pre-review checklist for the author before submitting for review

Every developer is encouraged to be familiar with our contributor guidelines.

  1. MR title and description help a friendly human understand the problem solved
  2. Sensible notes for the reviewer added to the section above to facilitate review
  3. MR fits the criteria of a "small change" listed below
  4. "WIP" or "Draft" removed from the MR title
  5. MR has a link to the original issue in the description, if it exists
  6. If the source branch is on a fork, MR is configured to allow commits from developers with access to push to the target branch
  7. Target branch set correctly. Default: master
  8. MR assigned to a capable reviewer. Default: @JWhitleyWork
What is meant by a "small change"?

This is a template with a trimmed-down checklist for small MRs. Use it when no new functions, classes or other things that require testing have been added.

Examples are changes to documentation only, a fix for an off-by-one error, improving the CI, or changing log messages to be more informative. When in doubt, use the regular template.

Checklist for the reviewer

Only the reviewer is allowed to make changes in this section!

Mark all the items that are done, and cross out items not applicable to this MR.

  1. Basic checks
    1. The MR title describes what is being done on the ticket
    2. The MR does not require additional tests or documentation to be written
    3. The first commit has a proper commit message to be used as a basis for the squashed commit created at the very end
  2. Code correctness
    1. The problem/feature is solved (reproducibly)
    2. The solution is performant enough for the use case in mind
    3. Any disabled lints inside the code or at the package level are justified
  3. Open work
    1. Any added source-code comment about future work refers to a follow-up GitLab issue explicitly; e.g., // TODO #551 refactor code below

If the MR provides an improvement, don't hesitate to add a 👍 emoji for a neat line of code or a "Thanks for implementing this" comment. This will reward the MR author and prevent the review from being only about what still needs to be improved.

Post-review checklist for the author

After receiving approval:

  1. All checkboxes in the MR checklist are checked or crossed out. Syntax example: 1. [ ] ~~this item crossed out~~
  2. Assign MR to maintainer with sufficient rights to merge. Default: @JWhitleyWork
Edited by Joshua Whitley

Merge request reports