Resolve "Change optional Analyses Overview to auto-comments"
Description
Implements two issues, they're so related that it's much less work and safer to work on them together.
- Removes all analyses categorization code, including
analyses-by-classified
resource and views. - Refactors some code to avoid duplication and make stuff cleaner.
- Adds a new postprocessor
analysis_tag_all_classified
. - Also fixes #104 (closed) with a small fix, reusing the new
load_analyses()
code so same analysis data is loaded everywhere in the Overview.
Related issues
#188 (closed) #178 (closed) #104 (closed)
Notes to review (code/docs/QA)
- e2e tests changed due to now using different variants for the tests (since a lot of variants previously came from not started analyses).
- Please give feedback on postprocessor name
Tests
General
-
Tests have been added that prove my fix is effective or that my feature works -
Related tests have been modified/removed
Hypothesis testing:
-
Soak testing has been done -
Distribution between positive / negative cases has been checked
Database
-
Includes changes to database schema -
Includes necessary database migrations
Configuration
-
Includes changes to configuration -
Includes configuration migration instructions in documentation
Merge checklist
-
Self-review of code has been performed. -
Feature review and validation against specification has been performed (if applicable). Apply label: QAdone -
Need for documentation has been evaluated and, if necessary, updated. Apply label: docsdone -
Code and implementation has been reviewed by other core developer (including any changes based on initial review). Apply label: code reviewdone
Closes #188 (closed) Closes #178 (closed) Closes #104 (closed)
Edited by Øyvind Evju