Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • openmw openmw
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 833
    • Issues 833
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenMWOpenMW
  • openmwopenmw
  • Merge requests
  • !1057

Sky shaders

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Cody Glassman requested to merge glassmancody.info/openmw:sky_shaders into master Jul 26, 2021
  • Overview 14
  • Commits 4
  • Pipelines 4
  • Changes 13

Enables use of shaders for sky and all its child nodes.

sky.cpp was getting quite large and was a nightmare of nested classes within classes, so I moved things around.

Lighting was quite expensive for weather particles, especially with legacy lighting where we iterate over every light so I've given them a special path in our object shaders.

Labeled as a draft as the sky is made of many different parts and I haven't gone through with a fine tooth comb yet, I plan to in near future. There was a bug or two with our previous sky and I wouldn't be surprised if there were more. Please, if you think something is off compare it to Morrowind.exe first and not the behavior of sky before this MR.

Should fix a few bugs I found along the way, closes: #5088 (closed) #6161 (closed) #6168 (closed)

Note: When shaders are enabled, occlusion queries seem to work on my iGPU drivers for first time with the sun. The culprit for me was the legacy style alpha testing, which this MR obviously doesn't use.

Edited Oct 23, 2021 by Cody Glassman
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sky_shaders