MyGUI 3.4.1 link error: "undefined reference to `typeinfo for MyGUI::ControllerRepeatClick'" (dynamic linking only)

Static linking of the newly released MyGUI 3.4.1 completes.

Dynamic linking, however, errors with "undefined reference to `typeinfo for MyGUI::ControllerRepeatClick'":

/usr/bin/ld: CMakeFiles/openmw.dir/mwgui/tradewindow.cpp.o:(.data.rel+0x4398): undefined reference to `typeinfo for MyGUI::ControllerRepeatClick'
/usr/bin/ld: CMakeFiles/openmw.dir/mwgui/alchemywindow.cpp.o:(.data.rel+0x4998): undefined reference to `typeinfo for MyGUI::ControllerRepeatClick'

Filed https://github.com/MyGUI/mygui/issues/213

changed the description

https://github.com/MyGUI/mygui/blob/master/MyGUIEngine/include/MyGUI_ControllerRepeatClick.h hasn't changed since 3.4.0 and neither's https://github.com/MyGUI/mygui/blob/master/MyGUIEngine/src/MyGUI_ControllerRepeatClick.cpp.

I thought maybe MyGUI_RTTI.h might have changed, but the only commit not in 3.4.0 is https://github.com/MyGUI/mygui/commit/274d8660ee2592b9507095f7b8417e8fcc8aefdc#diff-1e96d0726454875b22db8a768b97f4b2fdf9883432ddd5186d518d3027c60528 which seems pretty innocuous. Maybe it's something like https://stackoverflow.com/a/4184877/8585915

One thing that puzzles me is that we don't seem to be doing any RTTI with ControllerRepeatClick in tradewindow.cpp and alchemywindows.cpp.

They only do static_cast<MyGUI::ControllerRepeatClick*> which does not require RTTI.

Only isType and castType in MyGUI headers seem to use RTTI

MyGUI::ControllerItem* item = MyGUI::ControllerManager::getInstance().createItem(MyGUI::ControllerRepeatClick::getClassTypeName());

getClassTypeName is in the RTTI header.

getClassTypeName does not use RTTI, it returns a static string defined via a macro.

If I do this change to make it use more RTTI:

diff --git a/apps/openmw/mwgui/alchemywindow.cpp b/apps/openmw/mwgui/alchemywindow.cpp
index bacd1c769..1e0f26268 100644
--- a/apps/openmw/mwgui/alchemywindow.cpp
+++ b/apps/openmw/mwgui/alchemywindow.cpp
@@ -385,7 +385,7 @@ namespace MWGui
     void AlchemyWindow::addRepeatController(MyGUI::Widget *widget)
     {
         MyGUI::ControllerItem* item = MyGUI::ControllerManager::getInstance().createItem(MyGUI::ControllerRepeatClick::getClassTypeName());
-        MyGUI::ControllerRepeatClick* controller = static_cast<MyGUI::ControllerRepeatClick*>(item);
+        MyGUI::ControllerRepeatClick* controller = item->castType<MyGUI::ControllerRepeatClick>();
         controller->eventRepeatClick += newDelegate(this, &AlchemyWindow::onRepeatClick);
         MyGUI::ControllerManager::getInstance().addItem(widget, controller);
     }
diff --git a/apps/openmw/mwgui/tradewindow.cpp b/apps/openmw/mwgui/tradewindow.cpp
index 81d6a8ab3..e8e765459 100644
--- a/apps/openmw/mwgui/tradewindow.cpp
+++ b/apps/openmw/mwgui/tradewindow.cpp
@@ -374,7 +374,7 @@ namespace MWGui
     void TradeWindow::addRepeatController(MyGUI::Widget *widget)
     {
         MyGUI::ControllerItem* item = MyGUI::ControllerManager::getInstance().createItem(MyGUI::ControllerRepeatClick::getClassTypeName());
-        MyGUI::ControllerRepeatClick* controller = static_cast<MyGUI::ControllerRepeatClick*>(item);
+        MyGUI::ControllerRepeatClick* controller = item->castType<MyGUI::ControllerRepeatClick>();
         controller->eventRepeatClick += newDelegate(this, &TradeWindow::onRepeatClick);
         MyGUI::ControllerManager::getInstance().addItem(widget, controller);
     }

I get a different link error:

/usr/bin/ld: CMakeFiles/openmw.dir/mwgui/tradewindow.cpp.o: warning: relocation against `_ZTIN5MyGUI21ControllerRepeatClickE' in read-only section `.text._ZN5MyGUI7IObject8castTypeINS_21ControllerRepeatClickEEEPT_b[_ZN5MyGUI7IObject8castTypeINS_21ControllerRepeatClickEEEPT_b]'
/usr/bin/ld: CMakeFiles/openmw.dir/mwgui/tradewindow.cpp.o: in function `bool MyGUI::IObject::isType<MyGUI::ControllerRepeatClick>() const':
/home/gleb/repos/glebm/openmw/build/extern/fetched/mygui/MyGUIEngine/include/MyGUI_IObject.h:18: undefined reference to `typeinfo for MyGUI::ControllerRepeatClick'
/usr/bin/ld: CMakeFiles/openmw.dir/mwgui/tradewindow.cpp.o:(.data.rel+0x55f8): undefined reference to `typeinfo for MyGUI::ControllerRepeatClick'
/usr/bin/ld: CMakeFiles/openmw.dir/mwgui/alchemywindow.cpp.o:(.data.rel+0x5718): undefined reference to `typeinfo for MyGUI::ControllerRepeatClick'
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status
gmake[2]: *** [apps/openmw/CMakeFiles/openmw.dir/build.make:4531: openmw] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:3480: apps/openmw/CMakeFiles/openmw.dir/all] Error 2

There are other castType calls in that file, which makes me suspect ControllerRepatClick in particular

Ah, I think class ControllerRepeatClick should be class MYGUI_EXPORT ControllerRepeatClick

Yep that fixed it

Sent https://github.com/MyGUI/mygui/pull/215

mentioned in commit glebm/openmw@36cea207

mentioned in merge request !650 (merged)

mentioned in commit f8d32c05

closed with commit 36cea207

closed with merge request !650 (merged)

changed milestone to %openmw-0.47

added MyGUI label

removed milestone %openmw-0.47