Angelos Evripiotis authored Nov 07, 2018 and Angelos Evripiotis committed Nov 08, 2018

As someone coming from GitHub to GitLab, I was pleasantly surprised by
the 'filter by WIP status' option.

To make sure we get the most out of it, add a guideline to keep the
filter clean, to reduce reviewer burden.

Angelos Evripiotis authored Nov 07, 2018 and Angelos Evripiotis committed Nov 08, 2018

I was recently surprised that we don't prefer addressing review comments
in 'fixup!' commits.

Coming from GitHub, I've found that fixup commits make it easier for
reviewers to see what has changed since their last review. The idea is
to use '--autosquash' before landing to clean up the history again.

It's a pleasant surprise that it's easy to keep track of what changed in
merge-requests between pushes, so we can always keep the history clean.

Document this, so folks like me can see the light sooner.

Angelos Evripiotis authored Nov 07, 2018 and Angelos Evripiotis committed Nov 08, 2018

Explain why it's useful to mention the decisions made for a change and
provide links for background, e.g. issue numbers.

My general experience of git histories is that folks don't do enough
explaining, so it's great we have a contributing section for it.

I've found it's easier for folks to stick to rules when they know the
practical reasons for them, so provide some.

Add more to GitLab-relevant parts of contributing

See merge request !935

James Ennis authored Nov 07, 2018 and Javier Jardón committed Nov 08, 2018

This patch partially resolves #700

James Ennis authored Nov 08, 2018 and Javier Jardón committed Nov 08, 2018

Due to the changed Exception message, this patch also changes
the test_parse_size_over_1024T test in misc.py

Add local cache expiry documentation and fix misleading error message when specifying a percentage cache quota

Closes #700

See merge request !939

Previously, debug messages from `Plugin.__del__()` went to stdout
which was a problem for the test suite in extremely rare and hard to
predict circumstances.  This corrects that by sending the message to
stderr where all the rest of the messages tend to go.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

plugin.py: Redirect DEBUG from `__del__` to `sys.stderr`

See merge request !944

Fixes issue #574.

This will now return paths in the same order as list_relative_paths.

Direct CAS-to-CAS import

Closes #574

See merge request !911

As per PEP 0479 (https://www.python.org/dev/peps/pep-0479/),
StopIteration thrown in context managers are not valid starting from
Python 3.7.

source.py: don't let StopIteration propagate to silence() contextmanager

See merge request !945

Phillip Smyth authored Nov 07, 2018 and Jürg Billeter committed Nov 12, 2018

_project.py: Added validate_nodes() helper function to prevent duplicate lists

element-path was being used before node validation resulting in uncaught errors

Element path not validated before use

See merge request !937

Valentin David authored Nov 12, 2018 and Valentin David committed Nov 14, 2018

Fixes #755

Run tests on aarch64

Closes #369 and #755

See merge request !948

It's inconvenient to have to create a Linux platform to parse the bwrap version
and we want to get the version in a consistent manner.

If `bwrap` fails to set up the sandbox and start the payload command
it won't write an exit-code in --json-status-fd,
so we can report if it was a sandboxing failure if we don't get exit-code status
and a payload command failure if we do and it's non-zero.

Closes #286

Distinguish between bubblewrap sandboxing failure and command failure

Closes #286

See merge request !868

The Context was only used to obtain a reference to the CASCache
and set the unused cas_directory field.

If all you want is a subset of an artifact's output
using a cached extracted tree is unnecessary work.

By exposing the virtual CasBasedDirectory we can use `descend` to select a subtree
and `export_files` to read the contents.

Closes #234