Replace std::regex use with simpler resource_name parsing
Before raising this MR, consider whether the following are required, and complete if so:
-
Unit tests - Covered by existing tests -
Metrics - No additional needed -
Documentation update(s) - No additional needed
If not required, please explain in brief why not.
Description
While std::regex
is very flexible and useful, it has been known to cause issues with both bloat in code and not being very efficient. It is also overkill for it's current usage, which is parsing the resource_name
used in Bytestream
reads and writes. It's a well structured string and we only care about certain fields, so parsing it explicitly instead of using a regex is pretty simple.
This PR does exactly that to drop the parsing of std::regex
.
Validation
This code path is already covered by our tests, so building and running the tests should cover verifying this change.