Skip to content

Report back event flags

Guanhao Yin requested to merge sopium/wepoll-binding:master into master

I don't know why wepoll-binding was previously always reporting EventFlag::empty(), but it was really surprising, because linux epoll and wepoll(-sys) do report back event flags. Getting the event flags is very useful to determine what to do with the socket.

See also https://github.com/stjepang/smol/pull/127#discussion_r429029955

This merge request changes the iterator implementation to report back event flags, and changes/adds some tests accordingly.

This is strictly speaking a breaking change, but an empty flag is quite useless. I don't think that there are projects out there that are relying on the previous behavior. More likely, they would be surprised to find out that the flag is always empty, and just ignore the flag.

Merge request reports