Skip to content

Check if CIDRs are disjoint

Lavon Śpirydonaŭ requested to merge 602-check-if-cidrs-are-disjoint into devel

Version Control Information

Comment by Silvio

A comment in config.toml states that the wireguard subnets "[m]ust be set to a CIDR and must not conflict with the terraform.subnet_cidr." This is not enforced however and if disobeyed will result in strange connectivity issues where some VMs (that by chance ended up being in the wireguards CIDR) end upare unreachable from the workstation.

A check could either be implemented in update_inventory.py using https://docs.python.org/3/library/ipaddress.html#ipaddress.IPv4Network.subnet_of or in the wireguard role using https://docs.ansible.com/ansible/latest/collections/ansible/utils/docsite/filters_ipaddr.html

Source branch: 602-check-if-cidrs-are-disjoint
Target branch: devel

Commits:

Description

Feel free to add further information about your MR in this section

Closes: #

Merge Prerequisites

  • MR title (and description) are descriptive
  • Code is readable and syntactically correct
  • Code is understandable
  • Documentation has been updated, if necessary
  • Commit messages look good
  • Release note file added in latest commit

As a developer: please do not tick these boxes yourself. As a reviewer: please get yourself a hot cold beverage.

Closes #602 (closed)

Edited by Steve Starke

Merge request reports