Skip to content

Fix #386 for delValle2023 algorithm + documentation updates regarding aspherical rotation integration algorithms and initial conditions

Jérôme Duriezrequested to merge
density_scaling_aspherical into master

Trying to fix #386, I

  • modified NewtonIntegrator::leapfrogAsphericalRotateCarlos_2023 for a better application of NewtonIntegrator.densityScaling ideas (which I had and will probably never use(d) myself..)
  • put at least a warning in NewtonIntegrator::leapfrogAsphericalRotateOmelyan_1998 (I confess I got tired before reading a second paper and diving into yet another part of the code ;-) to be sure of the error and of the solution)
  • and took the opportunity for some doc cleaning / improvement. We for instance now have explained somewhere that we need to assign initial angular momentum for aspherical Fincham1992 rotations !.. (And not the other two "new" algorithms)

Note that I stopped before replacing the "third order" claim of delValle2023 with a "second order" one that would be more consistent with my understanding of Eq. (5) of the corresponding SPIRAL paper, and with the fact that the same paper tells (beginning of § 5) about an equal order between the SPIRAL algorithm and the leapfrog Verlet one for position, that our doc presents as second-order. Maybe that could be done in the future if everyone agrees (and once motivation re-builds up for some cleaning ;-) )

Merge request reports