Improvements for Ready system in warmup
This is a set of improvements (IMHO) and fixes for readying up when in warmup. I added them in separate commits in case any of them are unwelcome and can be reverted nicely.
Displays ready message as a noisy chat message instead of a console message; this makes it more visible that people are getting ready; it also reminds some forgetful people that we're in warmup. It looks like this:
-
Added the long overdue anti-flood for readying up so people can't spam it,
specially now that it's noisy. Hardcoded to 3 seconds. Could add a cvar. -
Fixes an issue where
ReadyCount()
wasn't getting called at the right time inPutObserverInServer()
. It was getting called before the player was transmuted to observer, so when someone went to spect, the spectator was still being counted as a player, creating a situation where if enough players were ready, but some of them went to spect, the game wouldn't start unless the players called unready and ready again. -
Disables the ready flag for players that go to spectator. I feel it's necessary that someone that went to spect for whatever reason should ready himself up again when he decides to join the game again; especially in the case of an AFK player.