DarkPlaces does not support alphaFunc GT0 and uses GE128 instead
By making this change, we ensure the materials look the same on DarkPlaces and other engines, even in the case it's wrong on DarkPlaces because Xonotic mappers now expect the wrong behavior.
Darkplaces only supports one alphaFunc operation, it only reads the alphaFunc keyword and does not read the function name:
It then uses the GE128 operator unconditionally:
https://gitlab.com/xonotic/darkplaces/blob/0ea8f691e05ea968bb8940942197fa627966ff99/render.h#L95
People may silently introduce regressions in their textures designed for GT0 by compressing them using a lossy picture format like Jpg.
Xonotic texture known to trigger this bug (in xonotic-maps):
models/desertfactory/textures/shaders/grass01.jpg
Using GT128 hides Jpg artifacts while it's possible a TGA version worked with GT0.
Xonotic texture that may benefit from GT0 if supported (in xonotic-maps):
models/desertfactory/textures/shaders/sign_ladder_dirty.jpg
By storing this texture in lossless format and making sure the frame is pure black and the ladder is a bit less black than pure black, only the frame would be transparent.
Unfortunately, after years of GT128 usagen displaying the texture with GT0 operation would be a regression.
Note: I also renamed some alphafunc
to alphaFunc
even if it was already GE128