WIP: Fix #1981 "Overtime does not work if score is 0"
WinningConditionHelper_equality = 0;
was added in 687b7077e "a stupid fix for a stupid bug breaking race"
https://github.com/smlinux/nexuiz/commit/687b7077ebbe2ed0897b3c2c9991c48576f20b00
but the obvious bug fix seems to be only:
- if not(p.race_completed)
+ if(p.race_completed)
the other change:
- if(readyplayers || playerswithlaps >= 2)
+ if(readyplayers || playerswithlaps >= 1)
was reverted 3 days later in 92541c07 "race: fix stupid typo :P" https://github.com/smlinux/nexuiz/commit/92541c079a8356dcb2783af3e44aa57091ca5fe9
So I doubt that line was really needed in that commit, not sure why divVerent added it.
I've tested my proposed bug fix in race, dm and ctf and works as expected. Can you see any drawback caused by this change?
Edited by Mario