Add a new function to copy fields from items to replacements

The engine's copyentity function inadvertently copies intrusive list data causing all sorts of issues, this change adds a QC function to copy item data to replacement items, avoiding the need to call the engine function and cleaning up various use cases of item replacing.

Closes #2792 (closed)

added MR SizeTiny label

mentioned in issue #2792 (closed)

// copyentity is an engine function which unintentionally copies intrusive list data
I think copyentity is intended to copy every field, even if some of them are involved in a particular arrangement of macros.

Copying intrusive list fields is an unintended side effect of the engine copying everything from the entity.

I commented about it because there was some confusion in chat as to whether this was an engine bug or a QC bug.

added 1 commit

• ec626feb - Remove an unclear comment about copyentity

Compare with previous version

copyentity is doing as it should, I removed the comment to avoid confusion.

approved this merge request

added 1 commit

• f9e57a10 - Fix a minor typo in a comment

Compare with previous version

approved this merge request

started a merge train

merged

mentioned in commit 351cb55e