Skip to content

Refactor loading screen and fix it

kiwixz requested to merge (removed):master into master

Fixes #256 (closed), #255 (closed) and #221 (closed).

I refactored the loading screen to use the same draw path as standard screen updates. This removes code duplication and hairy bugs, the standard path was already used but only in some cases...

#256 (closed) was due to the interaction between the "new" boolean introduced in fcb34623 and old globals we used for different things since long gone: drawing directly to the front buffer and not clearing before loading. Those old relics also caused the so-called flickers.

It still had no progressbar, so I removed the background fill of the status text. We clear the screen every refresh now anyway.

Also fixed the loading screen so it always triggers when restarting the renderer.

And finally, I immediately draw it when trying to connect to a server. This replaces a mostly black screen with just the old chat box while waiting for the server's initial response.

Fixes #374 (closed)

Edited by bones_was_here

Merge request reports