Skip to content

tokio-xmpp: Prevent XmppCodec from producing invalid stanza

pep requested to merge codec-invalid-stanza into master

This bug was introduced by 2e97f4de, to fix another bug where the parser would choke on whitespace.

The bug would manifest whenever a stanza was sent in different parts, for example:

<< "<message "
<< "type='chat><body>foo</body></message>"

Would produce the following once parsed:

<messagetype='chat'><body>foo</body></messagetype='chat'>

This commit ensures this doesn't happen anymore (by not trimming whitespaces before feeding the parser), and also ensures that whitespaces are now handled at the correct layer.

The removal of xmpp_codec::test_lone_whitespace only happens because I'm not sure if it's supposed to be here anymore. Maybe it should be at a different layer? Or written differently?

Signed-off-by: Maxime “pep” Buquet pep@bouah.net

Merge request reports