Skip to content

jid: Optimise for no-transform JIDs

Link Mauve requested to merge linkmauve/xmpp-rs:faster-jid into main

stringprep can make transformations to a JID, the most well-known one is making the nodepart and domainpart lowercase but it does much more than that.

It is extremely common to have to validate already-normalised JIDs though, and since https://github.com/sfackler/rust-stringprep/pull/4 this is exactly what the stringprep crate does, by returning Cow::Borrowed() for common ASCII-only cases.

This commit further reduces time spent by an additional -15%..-58% when already using this stringprep improvement, in addition to the 89.5%..98.5% change brought by this improvement (and +1.3% total when the JID isn’t normalised yet).

For instance, my own full JID parses in 1.83 µs before these changes, 132 ns with just the stringprep optimisation, and 51 ns with also this commit, on an i7-8700K.

Merge request reports