Skip to content

WIP: Server info

pep requested to merge ppjet6/xmpp-parsers:server_info into master

The first commit could be split (email change).

This implements XEP-0157: Contact Addresses for XMPP services on top of the data form abstraction provided by xmpp-parsers. I tested it with a small tokio-xmpp client, and it seems to be good.

In the one test I have for now, I a missing PartialEq on DataForm, (and ServerInfo, but I can add this one if necessary). I was wondering why there wasn't any PartialEq there. It doesn't seem to be implemented for other structs either, looking at other modules. What to do?

The code could probably be improved. I wasn't entirely sure about error messages, they might need rewording to fit the usual patterns. I am not currently checking that all there is in the form are *-addresses field + FORM_TYPE, I am only checking the number of fields and their types. We might want to change that.

Merge request reports