Skip to content
  • Jeff King's avatar
    pack-refs: prune top-level refs like "refs/foo" · afd11d3e
    Jeff King authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    After we have packed all refs, we prune any loose refs that
    correspond to what we packed. We do so by first taking a
    lock with lock_ref_sha1, and then deleting the loose ref
    file.
    
    However, lock_ref_sha1 will refuse to take a lock on any
    refs that exist at the top-level of the "refs/" directory,
    and we skip pruning the ref.  This is almost certainly not
    what we want to happen here. The criteria to be pruned
    should not differ from that to be packed; if a ref makes it
    to prune_ref, it's because we want it both packed and
    pruned (if there are refs you do not want to be packed, they
    should be omitted much earlier by pack_ref_is_possible,
    which we do in this case if --all is not given).
    
    We can fix this by switching to lock_any_ref_for_update.
    This behaves exactly the same with the exception of this
    top-level check.
    
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Reviewed-by: default avatarMichael Haggerty <mhagger@alum.mit.edu>
    Reviewed-by: default avatarRonnie Sahlberg <sahlberg@google.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    afd11d3e