Skip to content
  • Junio C Hamano's avatar
    attr: failure to open a .gitattributes file is OK with ENOTDIR · 8e950dab
    Junio C Hamano authored
    
    
    Often we consult an in-tree .gitattributes file that exists per
    directory.  Majority of directories do not usually have such a file,
    and it is perfectly fine if we cannot open it because there is no
    such file, but we do want to know when there is an I/O or permission
    error.  Earlier, we made the codepath warn when we fail to open it
    for reasons other than ENOENT for that reason.
    
    We however sometimes have to attempt to open the .gitattributes file
    from a directory that does not exist in the commit that is currently
    checked out.  "git pack-objects" wants to know if a path is marked
    with "-delta" attributes, and "git archive" wants to know about
    export-ignore and export-subst attributes.  Both commands may and do
    need to ask the attributes system about paths in an arbitrary
    commit.  "git diff", after removing an entire directory, may want to
    know textconv on paths that used to be in that directory.
    
    Make sure we also ignore a failure to open per-directory attributes
    file due to ENOTDIR.
    
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    8e950dab