Skip to content

Bump cmake-js from 6.3.2 to 7.0.0 in /src/audio/engine/libsamplerate

Wolf Yuan requested to merge dependabot/npm_and_yarn/src/audio/engine/libsamplerate/cmake-js-7.0.0 into main

Created by: dependabot[bot]

Bumps cmake-js from 6.3.2 to 7.0.0.

Release notes

Sourced from cmake-js's releases.

v7.0.0

This is a breaking change and will likely require some small changes to your cmake config to keep your project building.

Summary

A lot of work has gone into this release, to try and make the general usage of the library smoother. It has better support for building modules with node-api. The on disk footprint of the library is much smaller than before, with various dependencies removed, or updated.

Upgrading

We recommend having the following at the top of your cmake file, before the project(...) definition.

cmake_minimum_required(VERSION 3.15)
cmake_policy(SET CMP0091 NEW)
cmake_policy(SET CMP0042 NEW)

This will force MSVC to do a MT build, so if you were doing that another way, it should be possible to remove that. If you need to keep it building as MD, you can add set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL") in your cmake file.

If you are using node-api, make sure that your package.json has the following, but with the correct NAPI_VERSION filled in. We use this to autodetect that your module is building with node-api.

"binary": {
    "napi_versions": [7]
  },

You should also add the following to the bottom of your cmake file. This lets us avoid downloading the full nodejs headers, and lets us use bundle a much more lightweight copy instead

if(MSVC AND CMAKE_JS_NODELIB_DEF AND CMAKE_JS_NODELIB_TARGET)
  # Generate node.lib
  execute_process(COMMAND ${CMAKE_AR} /def:${CMAKE_JS_NODELIB_DEF} /out:${CMAKE_JS_NODELIB_TARGET} ${CMAKE_STATIC_LINKER_FLAGS})
endif()

If you have something like:

execute_process(COMMAND node -p "require('node-addon-api').include"
        WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
        OUTPUT_VARIABLE NODE_ADDON_API_DIR
        )
string(REPLACE "\n" "" NODE_ADDON_API_DIR ${NODE_ADDON_API_DIR})
string(REPLACE "\"" "" NODE_ADDON_API_DIR ${NODE_ADDON_API_DIR})
target_include_directories(${PROJECT_NAME} PRIVATE ${NODE_ADDON_API_DIR})

in your file, it is no longer needed. We will inject the correct include paths for you, similar to what is done for nan.

That should be everything.
If we missed something in these steps, or if you are having problems getting your module building again, let us know in an issue.

All changes:

  • update dependencies
  • replace some dependencies with modern language features

... (truncated)

Changelog

Sourced from cmake-js's changelog.

v7.0.0 - 08/10/22

  • update dependencies
  • replace some dependencies with modern language features
  • follow node-gyp behaviour for visual-studio version detection and selection
  • automatically locate node-addon-api and add to include paths
  • avoid downloads when building for node-api
  • encourage use of MT builds with MSVC, rather than MD

v6.3.1 - 05/06/22

  • add missing bluebird dependency
  • fix platform detection for visual studio 2019 and newer
  • fix platform detection for macos

v6.3.0 - 26/11/21

v6.2.1 - 20/07/21

  • EOL hotfix (Thx Windows!)

v6.2.0 - 19/07/21

  • various fixes

v6.1.0 - 27/02/20

  • Add support for "-A/--platform" option to make target platform selectable for Visual Studio 2019 generator: cmake-js/cmake-js#201

v6.0.0 - 30/09/19

  • Dropped compatibility of old Node.js runtimes (<10.0.0)
  • --cc and --cxx flags for overriding compiler detection: cmake-js/cmake-js#191

v5.3.2 - 21/08/19

  • Visual Studio detection fixes

... (truncated)

Commits
  • 110c563 v7.0.0
  • 46fba95 chore: update dependencies
  • 6712a0f feat: Set CMAKE_MSVC_RUNTIME_LIBRARY to encourage use of MT builds
  • c99e10e fix: Update win_delay_load_hook.cc based on nw.js
  • 2be9d8f v7.0.0-3
  • 261e462 fix: typo
  • b205e13 fix: typo
  • a38fd3a chore: add some more keywords
  • 3e4558f chore: update baseurl for electron mirror (#279)
  • 0e2c948 fix(msvc): node.lib should be generated as part of the configure step
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Merge request reports