Skip to content
Snippets Groups Projects

CIGI: Use a dissector table for packet id for version 3

Merged John Thacker requested to merge johnthacker/wireshark:cigi into master

Use a dissector table for dissecting different packet ID types for CIGI version 3.

This allows other dissectors (e.g., in Lua) to register to the table to dissect user defined packet types.

Also fix the dissection of unknown/data in CIGI 4; the common function was looking at the previous byte to determine the packet length, but as CIGI 4 uses a different header (with a 2 byte length in a different offset), this didn't work. Instead take a proper subset based on the reported length.

The minor versions of CIGI 3 just add fields in previously reserved places. There's no need to register identical fields (with identical abbreviations), so remove a lot of duplicate fields.

This approach should be extended to CIGI 2 and 4 later.

Merge request reports

Merge request pipeline #1387375383 skipped

Merge request pipeline skipped for 8abd58d9

Merged by AndersBromanAndersBroman 8 months ago (Jul 25, 2024 7:05am UTC)

Loading

Pipeline #1387441909 canceled

Pipeline canceled for 8abd58d9 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading