sflow decode error for some extended formats

This issue was migrated from bug 5379 in our old bug tracker.

Original bug information:

Reporter: Andrew Feren
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: All
Platform: Other
Version: Git

Attachments:

sflow.patch: patch for sflow

The following functions are returning the length of the structure when the offset is expected.

• dissect_sflow_245_extended_switch
• dissect_sflow_245_extended_router

I'm seeing the following error

09:23:43          Warn Dissector bug, protocol sFlow, in packet 1: proto.c:3802: failed assertion "end >= fi->start"

patch attached.

While I was in there I ...

• added modelines for the next person.
• consolidated some common decodes to a single function dissect_sflow_245_address_type(...)