Skip to content

Detect and handle a deleted contact during unidentified sending

Matti Viljanen requested to merge handle-deleted-contact into main

It looks like detecting a deleted contact broke with unidentified sending. If a contact is not registered anymore:

  • Try sending using unidentified
  • Get a 401 Unauthorized
  • Fallback to identified
  • Get a 404 Not found
  • Fail the old path, skipping the 404 catch block :(

This PR is an attempt to fix that; it simply detects MessageSenderError::NotFound[ uuid } and performs the same deletion logic. It's a copy-paste mess initially, but this raises the question; what else did unidentified sending broke?

Merge request reports