Set default attachment MIME type to application/octet-stream (!295) · Merge requests · Whisperfish / Whisperfish

Matti Viljanen requested to merge set-default-mime-type into master Sep 18, 2022

If the MIME type guesser fails (no file extension), assume application/octet-stream and continue.

Tested by sending png-with-no-extension to Signal Android, which received the file, instead of Whisperfish crash.

Behavior: Signal Android didn't figure out that it's a PNG file from magic bytes, and Whisperfish doesn't show a thumbnail either. This might be fixable by doing a "proper" MIME type detection using file contents if file extension fails, but this at least prevents Whisperfish crash, and lets the file to be sent. Images without extension are quite a corner case, after all.

Fixes #454 (closed)

Set default attachment MIME type to application/octet-stream

Merge request reports