Always cancel racy tasks
@krisbreuker @webhare_rob I see regular testfails caused by mail still stuck in the mailloops.
eg, testcustomformfile failed on
RECORD ARRAY mails := testfw->ExtractAllMailFor("testfw+formtest@beta.webhare.net", [ timeout := 0, count := 2 ]);
with having count '3'. obviously caused by a testrun I just did before... the test does cancel these:
], [ canceltasks := ["publisher:mailfeedback","publisher:mailresults"]
but to prevent this race, it should have also cancelled system:outgoingmail
instead of ad-hoc adding canceltasks whenever a test races and I've had time to investigate the issues (which I've done plenty over the last year), I wanted to suggest
- always cancel publisher:mailfeedback, publisher:mailresults, system:outgoingmail
Do you see any objection to that?
And if not: do you see any objection to cancelling ALL pending tasks at the start of a test run ?