Skip to content

WIP: Init AccountCommon.kt from Account.kt

Jørgen Svennevik Notland requested to merge jQrgen/wally:mp_account into mp

Portly only what is needed to create an account in this MR

Convert to Common Kotlin in commonKotlin/Account_common.kt based on androidMain/Account.kt

Common Kotlin and Compose code should support JVM, Android, iOS and MacOS.

Moved to:

Business logic tasks

  • port EncodePIN to common kotlin
  • SaveAccountPin
  • Implement in wallyApp!!.getElectrumServerOn(it) common kotlin
  • Call cnxnMgr.exclusiveNodes(nodeSet) in common kotlin
  • Call cnxnMgr.preferNodes(nodeSet) in common kotlin
  • Implement InvalidKeySpecException(ignore invalid PIN) when user entered invalid PIN in common kotlin
  • Implement saveAccountAddress in common kotlin
  • Port infoGUI to StateFlow
  • Port encodedPin to StateFlow
  • Port currentReceive to StateFlow
  • Port fiatPerCoin to StateFlow
  • Port confirmedBalance to StateFlow
  • Port cryptoFormat to StateFlow
  • Add data class and MustableStateFlow for lockIcon image and visibility in AccountCommon
  • Port @Synchronized fun start() to common kotlin

Use Compose Multiplatform instead of functions such as fun setUI(..)

Maybe Compose Multiplatform tasks should be divided into seperate tasks for each respective screen?

UI // Compose Multiplatform tasks

  • Display data from laterUI(..) calls in Compose Multiplatform (Move to own MR for Compose?)
  • Display wallet.getBalanceIn(it) in Compose Multiplatform
  • saveActiveAccountList
  • Implement or delete: Code encapsulated by: if (act != null && act is CommonNavActivity)

Partially moved to: https://gitlab.com/wallywallet/android/-/merge_requests/28/diffs#638898d8c6e834d3ff974e5df59ef093014f54be and https://gitlab.com/wallywallet/android/-/merge_requests/46

Edited by Jørgen Svennevik Notland

Merge request reports