Skip to content

tentativeFixOne for Issue 509

Daniel Andrei R. Garcia requested to merge bugFix509 into master

For Issue: #509 (closed)

The title of the issue is "Empty table (No wallets shown) when page parameter is higher then current search last page value & various related console errors."

Emanuel mentioned the issue that when a shared link like https://walletscrutiny.com/?platform=iphone&page=2&query-string=android is visited, the result is an empty page with no wallets shown.

This means that when the page parameter in the URL exceeds the total number of available pages for the current search results (determined by platform and query-string), the table of wallets is not displayed, which is not the desired behavior.

Instead, when such a scenario occurs, Emanuel likely expects the system to handle it gracefully, such as by defaulting to the last available page of the search results or showing the entire collection of wallets, rather than displaying an empty table.

I've added the logic to check and correct the page number in the buildWalletGridAndPaginationUI function. If the page number is less than 1 or exceeds the maxPages, it defaults to the maxPages, ensuring that the user always sees relevant content instead of an empty page.

I've also introduced some overrides to manual editing of the url:

A search for 'android' on the 'iphone' platform will instead show 'all android apps'

As seen in this screenshot:

image

I was not able to replicate the console issues referenced in the same issue number and instead received a manifest.json error - a file which does not exist locally.

Edited by Daniel Andrei R. Garcia

Merge request reports