Skip to content

Fix accidental jump cancellation during dispatch of `NpcActivity::Goto`

Dmitriy Kashitsyn requested to merge veloren/dev/veloren:x7cfe/fix_npc_goto_jump into master

AgentData::jump_if cancels InputKind::Jump if condition is not met. Even if the jump itself was issued elsewhere. This prevented merchants and travelers from reaching target site if somewhere along the path jump is required.

This is exactly what happens during dispatch of NpcActivity::Goto. Original implementation contained traverse followed by jump_if for flying NPCs which cancelled pending InputKind::Jump issued by traverse.

This fix extends jump condition inside traverse by including traversal_config.can_fly.

  • By opening this merge request, you agree to release your code and all other changes under the GPL 3 license and to abide by the terms set by this license.
  • Migrations have been added if applicable (migrations are always necessary for removing/renaming item asset files)
  • Significant changes of this merge request have been added to the changelog.
Edited by Dmitriy Kashitsyn

Merge request reports