Skip to content

Make shaderc optimization off by default for now

Imbris requested to merge veloren/dev/veloren:imbris/shaderc-opt-default-off into master

wgpu currently rejects if fragment shader inputs are optimized out such that they don't match fragment shader outputs.

With how dynamically configurable our shader code is, we can't reasonably manually handle all the cases where fragment shader inputs end up being unused without making the code excessively verbose.

See this issue to fix this in wgpu https://github.com/gfx-rs/wgpu/issues/3748.

Unfortunately, this optimization was helping fix some issues (e.g. figure texture sampling coordinates being broken) that appeared on AMD + Windows + Vulkan (e.g. rx 580 and similar cards).

  • By opening this merge request, you agree to release your code and all other changes under the GPL 3 license and to abide by the terms set by this license.
  • Migrations have been added if applicable (migrations are always necessary for removing/renaming item asset files)
  • Significant changes of this merge request have been added to the changelog.

Merge request reports