Draft: Inventory System overhaul — High Level Design Discussion
Because holy hell the yelling has to stop already. Please.
This is a MR to guide the regular discussion rounds in Discord into a more appropiate format; most importantly one that's much easier to back-reference later on. The actual text of the RFC is bland right now and will be filled in with the details as soon as we actually start nailing those down, we're not even close to that right now.
<radio advertisement voice>
Do you have opinions about Inventory Systems? Do you just know how an inventory system is done properly? Do you have a very clear idea what the right way for the inventory in veloren is? Aunt Nadja wants you to help us design the best inventory Veloren could ever have!
</radio advertisement voice>
Process
If this is your first encounter with RFCs and the RFC process, here's what you do:
You have an idea about how the inventory and limits that it imposes for gameplay purposes could look like? (Weight-based, Slot-based, Volume-based)
Great! We do want to hear your ideas! The easiest way is to just comment below. But, please read the existing comments first, maybe it turns out somebody had the same idea you had. In that case, write about what you would do specifically different from their idea. That way we repeat ourselves less. If you like their idea a real lot, add a
And keep in mind: A short "just so I don't forget;" comment with a few bullet points of things you thought about but didn't flesh out is much better than absolute silence because you think RFC comments have to be super polished. Please don't hesitate to comment :)
If you already have a pretty detailed concept with fleshed out implementation details that you would like to offer, consider instead updating the actual RFC text. The best way is to make a new merge request on the working branch of this RFC (veloren/dev/rfcs:dequbed/0000-inventory-system-overhaul), changing the text with your system. That way we can talk about the details of your idea using the very good code review tools gitlab offers (e.g. adding comments to specific lines i.e. bullet points in your proposal)
You don't particularly have a specific idea but you have a question about a point in the RFC text or something that somebody discussed in a previous comment or in Discord?
That's cool! Please add your question as comments (generally the "Start a thread" button is a good choice here), if you had it then others may have the same question! Don't be afraid to ask, we don't bite. :)
This person has like the worst idea! Like that is a super bad idea and I want to shame their cow!
Please don't. We're all friends here. We love a good argument-based discussion but please, keep the human behind the screen in mind. And different people have different experiences. Somebody else may have much more experience with one style of inventory and like it more, you may had a different experience. In the end we all want the best system and we'll get it the fastest by working together and being nice.
Oh god this RFC will end up with a thousand comments! 😰
Yes, and honestly, that's a good thing! If it does we can always go back here even in several years time and check up on why we did things the way we did them. All the rationale is still there, in the original form. Having that resource is super helpful for future us. :)
Postscript
This shitpost was made thanks to coffee.